LiShuMing commented on a change in pull request #1283: [CALCITE-3153] Improve
testing in TpcdsTest using assertEqual instead of printing results
URL: https://github.com/apache/calcite/pull/1283#discussion_r298487891
##########
File path: plus/src/test/java/org/apache/calcite/adapter/tpcds/TpcdsTest.java
##########
@@ -164,30 +165,30 @@ private static String schema(String name, String
scaleFactor) {
@Test public void testTableCount() {
final CalciteAssert.AssertThat with = with();
-// foo(with, "CALL_CENTER", 6);
-// foo(with, "CATALOG_PAGE", 11_718);
-// foo(with, "CATALOG_RETURNS", 144_067);
-// foo(with, "CATALOG_SALES", 1_441_548);
-// foo(with, "CUSTOMER", 100_000);
-// foo(with, "CUSTOMER_ADDRESS", 50_000);
-// foo(with, "CUSTOMER_DEMOGRAPHICS", 1_920_800);
-// foo(with, "DATE_DIM", 73_049);
-// foo(with, "HOUSEHOLD_DEMOGRAPHICS", 7_200);
-// foo(with, "INCOME_BAND", 20);
-// foo(with, "INVENTORY", 11_745_000);
-// foo(with, "ITEM", 18_000);
-// foo(with, "PROMOTION", 300);
-// foo(with, "REASON", 35);
-// foo(with, "SHIP_MODE", 20);
-// foo(with, "STORE", 12);
-// foo(with, "STORE_RETURNS", 287_514);
-// foo(with, "STORE_SALES", 2_880_404);
-// foo(with, "TIME_DIM", 86_400);
-// foo(with, "WAREHOUSE", 5);
-// foo(with, "WEB_PAGE", 60);
-// foo(with, "WEB_RETURNS", 71_763);
-// foo(with, "WEB_SALES", 719_384);
-// foo(with, "WEB_SITE", 30);
Review comment:
Thanks for @zabetak 's replies. Those tables' rowCounts are added in
`org.apache.calcite.adapter.tpcds.TpcdsSchema`, it uses TABLE_ROW_COUNTS
mapping to maintaince tables' rowCounts. So I think there's no cost to generate
data?
Maybe it's better to open up these tests again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
