rubenada commented on a change in pull request #1282: [CALCITE-3151] RexCall's
Monotonicity is not considered in determinin…
URL: https://github.com/apache/calcite/pull/1282#discussion_r298497744
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdCollation.java
##########
@@ -240,7 +241,13 @@ private RelMdCollation() {}
* {@link org.apache.calcite.rel.core.Calc}'s collation. */
public static List<RelCollation> calc(RelMetadataQuery mq, RelNode input,
RexProgram program) {
- return program.getCollations(mq.collations(input));
Review comment:
With this change, `RexProgram#getCollations` seems to be unused. Maybe we
should tag it as deprecated for the next version, and eventually remove it in a
subsequent version, to avoid leaving unnecessary code behind:
```
public class RexProgram {
...
/**
* Given a list of collations which hold for the input to this program,
* returns a list of collations which hold for its output. The result is
* mutable and sorted.
* @deprecated Use {@link RelMdCollation#calc}
*/
@Deprecated // to be removed before 2.0
public List<RelCollation> getCollations(List<RelCollation>
inputCollations) { ... }
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
