hsyuan commented on a change in pull request #1286: CALCITE-3155 : Fixing bug
in the unparse of UNION_ALL SqlSetOperator when it has no operands
URL: https://github.com/apache/calcite/pull/1286#discussion_r298811043
##########
File path:
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
##########
@@ -490,10 +505,10 @@ public boolean hasTrickyRollup(Sort e, Aggregate
aggregate) {
return !dialect.supportsAggregateFunction(SqlKind.ROLLUP)
&& dialect.supportsGroupByWithRollup()
&& (aggregate.getGroupType() == Aggregate.Group.ROLLUP
- || aggregate.getGroupType() == Aggregate.Group.CUBE
- && aggregate.getGroupSet().cardinality() == 1)
+ || aggregate.getGroupType() == Aggregate.Group.CUBE
+ && aggregate.getGroupSet().cardinality() == 1)
&& e.collation.getFieldCollations().stream().allMatch(fc ->
- fc.getFieldIndex() < aggregate.getGroupSet().cardinality());
+ fc.getFieldIndex() < aggregate.getGroupSet().cardinality());
Review comment:
Can you revert these indent changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
