danny0405 commented on a change in pull request #1293: [CALCITE-3165]
Project#accept(RexShuttle shuttle) does not update rowType
URL: https://github.com/apache/calcite/pull/1293#discussion_r299440278
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Project.java
##########
@@ -145,6 +146,12 @@ public RelNode accept(RexShuttle shuttle) {
if (this.exps == exps) {
return this;
}
+ final RelDataType rowType =
+ RexUtil.createStructType(
Review comment:
I'm curious about when we need to invoke this `Project#accept(RexShuttle)`,
usually people would customize the shuttle logic through extending a new
shuttle implementation. And if want to change the project, we would implement a
new `visit(Project)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
