julianhyde edited a comment on issue #1293: [CALCITE-3165] Project#accept(RexShuttle shuttle) does not update rowType URL: https://github.com/apache/calcite/pull/1293#issuecomment-507792491 Please revise the javadoc for `RelNode.accept(RexShuttle)` making it clear that the new RelNode might have a different row-type. Might the new RelNode have a different number of fields? You decide. Do you think that we are placing an undue burden on clients of `RelNode.accept`? If we are, we should not make this change, and instead we should throw if the row type changes. When you add a new test please modify `CalciteSuite.java`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
