asereda-gs commented on a change in pull request #800:
[CALCITE-2460][CALCITE-2459] Add implementation of To_Base64 and From_Base64
to SqlFunctions
URL: https://github.com/apache/calcite/pull/800#discussion_r300133774
##########
File path: core/src/test/java/org/apache/calcite/test/SqlFunctionsTest.java
##########
@@ -76,6 +78,34 @@
assertEquals("a bcd iijk", lower("A bCd Iijk"));
}
+ @Test public void testFromBase64() {
Review comment:
Can you also add to/from tests ? Presumably `fromBase64(toBase64(x)) == x`.
```java
// add more examples as you see fitted
for(String expected: Arrays.asList("", "\0", "0", "a", " ", "\n", "\r\n",
"\u03C0")) {
String result = fromBase64(toBase64(expected));
assertEquals(result, expected);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
