DonnyZone commented on a change in pull request #1307: [CALCITE-3182] Trim
unused fields for plan of materialized-view before matching.
URL: https://github.com/apache/calcite/pull/1307#discussion_r301120882
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -495,8 +495,9 @@ assert equalType(
for (MutableRel targetDescendant : targetDescendants) {
MutableRel queryDescendant = map.get(targetDescendant);
if (queryDescendant != null) {
- assert queryDescendant.rowType.equals(targetDescendant.rowType);
- equivalents.put(queryDescendant, targetDescendant);
Review comment:
>
>
> @DonnyZone @rubenada
> THX a lot for review this.
> Sure I will add a comment line soon for this.
>
> > We can add a test for this exception.
>
> hmm... Actually what I'm doing is to release the assert and avoid the
exception, so maybe it's hard to test the exception catching.
I have also noticed this exception, you can use a similar example as that in
[CALCITE-3113](https://issues.apache.org/jira/browse/CALCITE-3113).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
