rubenada commented on a change in pull request #1310: [CALCITE-3113] Equivalent
MutableAggregates with different row types should match with each other.
URL: https://github.com/apache/calcite/pull/1310#discussion_r301669186
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -542,9 +556,7 @@ assert equalType(
equivalents.remove(slots[i], equi.iterator().next());
}
}
- assert result.result.rowType.equals(result.call.query.rowType)
- : Pair.of(result.result, result.call.query);
- equivalents.put(result.result, result.call.query);
+ equivalents.put(result1, result.call.query);
Review comment:
I think that we could keep the assert, but using `result1` instead of
`result.result`:
```
assert result1.rowType.equals(result.call.query.rowType)
: Pair.of(result1, result.call.query);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
