jinxing64 commented on a change in pull request #1310: [CALCITE-3113]
Equivalent MutableAggregates with different row types should match with each
other.
URL: https://github.com/apache/calcite/pull/1310#discussion_r301685751
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -542,9 +556,7 @@ assert equalType(
equivalents.remove(slots[i], equi.iterator().next());
}
}
- assert result.result.rowType.equals(result.call.query.rowType)
- : Pair.of(result.result, result.call.query);
- equivalents.put(result.result, result.call.query);
+ equivalents.put(result1, result.call.query);
Review comment:
Hmm, this change only compensate the "top" target (when `targetDescendant ==
target`), but there's chance that child-node of target is equivalent with
child-node of query, while they have different row-types. That's why I removed
this this `assert`. If we keep it here, the test case I added will fail
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
