jh3507 commented on a change in pull request #1309: [CALCITE-3183] Trimming
method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r302739181
##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -1146,7 +1146,7 @@ public RelBuilder functionScan(SqlOperator operator,
* and optimized in a similar way to the {@link #and} method.
* If the result is TRUE no filter is created. */
public RelBuilder filter(RexNode... predicates) {
- return filter(ImmutableList.copyOf(predicates));
+ return filter(ImmutableList.copyOf(predicates), Collections.emptyList());
Review comment:
I think Laurent is mentioning predicates argument which is converted into a
single RexNode condition in the builder, and the one that is passed along and
end up as an ImmutableSet is correlation variables. So, I think we could use
ImmutableSet for correlation variables and, for predicates, we can pass a list.
Updated in the new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
