danny0405 commented on a change in pull request #1313: [CALCITE-3190]
ElasticsearchJson throws Exception when visitMappingProperties
URL: https://github.com/apache/calcite/pull/1313#discussion_r302823938
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchJson.java
##########
@@ -97,42 +95,33 @@ static void visitMappingProperties(ObjectNode mapping,
BiConsumer<String, String> consumer) {
Objects.requireNonNull(mapping, "mapping");
Objects.requireNonNull(consumer, "consumer");
- visitMappingProperties(new ArrayDeque<>(), mapping, consumer);
+ visitMappingProperties("", mapping, consumer);
}
- private static void visitMappingProperties(Deque<String> path,
- ObjectNode mapping, BiConsumer<String, String> consumer) {
+ private static void visitMappingProperties(String prefix, ObjectNode mapping,
+ BiConsumer<String, String>
consumer) {
Objects.requireNonNull(mapping, "mapping");
Review comment:
Let's follow other Calcite code's continuous indent, the default code check
didn't check this but we should follow the common pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
