laurentgo commented on a change in pull request #1311: [CALCITE-3187] Make
decimal type inference overridable
URL: https://github.com/apache/calcite/pull/1311#discussion_r303749114
##########
File path:
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactoryImpl.java
##########
@@ -457,54 +456,13 @@ public static boolean isJavaType(RelDataType t) {
}
/**
- * {@inheritDoc}
- *
- * <p>Implement RelDataTypeFactory with SQL 2003 compliant behavior. Let p1,
- * s1 be the precision and scale of the first operand Let p2, s2 be the
- * precision and scale of the second operand Let p, s be the precision and
- * scale of the result, Then the result type is a decimal with:
- *
- * <ul>
- * <li>p = p1 + p2</li>
- * <li>s = s1 + s2</li>
- * </ul>
- *
- * <p>p and s are capped at their maximum values
- *
- * @see Glossary#SQL2003 SQL:2003 Part 2 Section 6.26
+ * Delegates to RelDataTypeSystem#deriveDecimalMultiplyType to get the
return type
Review comment:
use `{@link ...}` to actually link to the method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
