michaelmior commented on issue #1285: [CALCITE-3154] RelToSqlConverter generated Nulls Last and Nulls First when convert RexOver to sql using MysqlSqlDialect. URL: https://github.com/apache/calcite/pull/1285#issuecomment-513354601 @julianhyde Fair point. Forgive me for misinterpreting the guidelines. I somewhat disagree, because I think commit message should describe what was done. That said, I agree that based on the context, a description of a bug in a commit message implies that the commit fixes the bug. I would personally reverse the two paragraphs but I think either is acceptable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
