kgyrtkirk commented on a change in pull request #1322: [CALCITE-3198]
ReduceExpressionsRule.FILTER_INSTANCE does not reduce 'NOT(x=a AND x=b)'
URL: https://github.com/apache/calcite/pull/1322#discussion_r305635453
##########
File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java
##########
@@ -1581,6 +1588,13 @@ private void checkExponentialCnf(int n) {
final RexLiteral literal3 =
rexBuilder.makeExactLiteral(BigDecimal.valueOf(3));
final RexLiteral literal4 =
rexBuilder.makeExactLiteral(BigDecimal.valueOf(4));
+ // "a <> 1 or a <> 2" ==> "true"
+ checkSimplifyFilter(
Review comment:
I know we have a lot of these "big" multi-testcase tests in rexprogramtest;
but if possible - could you please organize the new testcases to be
individually executable - it's so much easier to debug a single testcase in
case something breaks...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
