danny0405 commented on a change in pull request #1301: [CALCITE-3175]
AssertionError during serializing RexLiteral with Enum type.
URL: https://github.com/apache/calcite/pull/1301#discussion_r307105004
##########
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##########
@@ -59,7 +63,7 @@
/**
* Unit test for {@link org.apache.calcite.rel.externalize.RelJson}.
*/
-public class RelWriterTest {
+public class RelWriterTest extends SqlToRelTestBase {
public static final String XX = "{\n"
Review comment:
Can you take a look at what is `SqlToRelTestBase` used for ? Not just say
that "Oh, this extend works for me!".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
