jh3507 commented on a change in pull request #1334: [CALCITE-3111] Allow custom
implementations of Correlate in RelDecorr…
URL: https://github.com/apache/calcite/pull/1334#discussion_r307893288
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java
##########
@@ -1219,10 +1283,12 @@ public Frame decorrelateRel(LogicalJoin rel) {
return null;
}
- final RelNode newJoin =
- LogicalJoin.create(leftFrame.r, rightFrame.r,
- decorrelateExpr(currentRel, map, cm, rel.getCondition()),
- ImmutableSet.of(), rel.getJoinType());
+ final RelNode newJoin = relBuilder
+ .push(leftFrame.r)
+ .push(rightFrame.r)
+ .join(rel.getJoinType(), decorrelateExpr(currentRel, map, cm,
rel.getCondition()),
+ ImmutableSet.<CorrelationId>of())
Review comment:
Yes. I removed all '"<CorrelationId>"' from my change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
