julianhyde commented on a change in pull request #1334: [CALCITE-3111] Allow
custom implementations of Correlate in RelDecorr…
URL: https://github.com/apache/calcite/pull/1334#discussion_r307944913
##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -2286,6 +2301,13 @@ public RelBuilder sortLimit(int offset, int fetch,
RexNode... nodes) {
return sortLimit(offset, fetch, ImmutableList.copyOf(nodes));
}
+ /** Creates a {@link Sort} by collation, with limit and offset. */
+ public RelBuilder sortLimit(RelCollation collation, RexNode offset, RexNode
fetch) {
+ final RelNode sort = sortFactory.createSort(peek(), collation, offset,
fetch);
+ replaceTop(sort);
+ return this;
+ }
+
Review comment:
This method is not necessary. Instead of `builder.sortLimit(collation,
offset, fetch)` you can call `builder.sortLimit(offset, fetch,
builder.fields(collation))`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
