danny0405 commented on a change in pull request #1322: [CALCITE-3198]
ReduceExpressionsRule.FILTER_INSTANCE does not reduce 'NOT(x=a AND x=b)'
URL: https://github.com/apache/calcite/pull/1322#discussion_r307953576
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -673,7 +674,7 @@ private RexNode simplifyIs2(SqlKind kind, RexNode a,
RexUnknownAs unknownAs) {
return simplify(a, unknownAs);
} else {
RexNode newSub =
- simplify(a, kind == SqlKind.IS_TRUE ? RexUnknownAs.FALSE :
RexUnknownAs.TRUE);
+ simplify(a, kind == SqlKind.IS_TRUE ? RexUnknownAs.FALSE : TRUE);
Review comment:
Can we keep it as RexUnknownAs.TRUE to make the code more readable ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
