danny0405 commented on issue #1328: [CALCITE-3207] Fail to convert Join RelNode with like condition to sql statement URL: https://github.com/apache/calcite/pull/1328#issuecomment-515818317 > @danny0405 > Thank you for reviewing my code. > I think there is more common way to handle this case , when condition syntax is in the `join` expression, just like the handler of the `filter` expression. > If my thoughts is wrong, Please tell me to correct my mistake. I think the main reason that the SqlImplementor needs to handle the join condition separately is that the `Join` has 2 `Context`[1], and each binary operators needs to figure out which context their operands references belong to, so sync the logic with `Filter` seems not a good idea. [1] https://github.com/apache/calcite/blob/689a5bbb14614d3f8eef4a4f7e832c6c02029b3c/core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java#L422
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
