DonnyZone commented on a change in pull request #1342: [CALCITE-3220] HiveSqlDialect transforms function Trim to correct Hive format URL: https://github.com/apache/calcite/pull/1342#discussion_r309152630
########## File path: core/src/test/java/org/apache/calcite/sql/dilect/HiveSqlDialectTest.java ########## @@ -0,0 +1,58 @@ +/* Review comment: You can test the function in RelToSqlConverterTest. A new HiveSqlDialectTest is not necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
