vlsi commented on a change in pull request #1347: [CALCITE-3224] New
RexNode-to-Expression CodeGen Implementation
URL: https://github.com/apache/calcite/pull/1347#discussion_r309684774
##########
File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
##########
@@ -2372,12 +2372,12 @@ private void
checkNullableTimestamp(CalciteAssert.Config config) {
CalciteAssert.hr()
.query(
"select upper((case when \"empid\">\"deptno\"*10 then \"name\"
end)) T from \"hr\".\"emps\"")
- .planContains(
- "final String inp2_ = current.name;")
- .planContains("return current.empid <= current.deptno * 10 "
- + "|| inp2_ == null "
- + "? (String) null "
- + ": org.apache.calcite.runtime.SqlFunctions.upper(inp2_);")
+// .planContains(
+// "final String inp2_ = current.name;")
+// .planContains("return current.empid <= current.deptno * 10 "
Review comment:
Please fix relevant tests.
In other words, for now you comment the generated code, and it is not clear
what code is produced out of a new genertor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
