kgyrtkirk commented on a change in pull request #1339: [CALCITE-3215]
Simplification may not fully simplify IsNotNull expres…
URL: https://github.com/apache/calcite/pull/1339#discussion_r310038824
##########
File path:
core/src/test/java/org/apache/calcite/test/fuzzer/RexProgramFuzzyTest.java
##########
@@ -65,7 +65,7 @@
private static final Duration TEST_DURATION =
Duration.of(Integer.getInteger("rex.fuzzing.duration", 5),
ChronoUnit.SECONDS);
- private static final long TEST_ITERATIONS =
Long.getLong("rex.fuzzing.iterations", 18);
+ private static final long TEST_ITERATIONS =
Long.getLong("rex.fuzzing.iterations", 2000);
// Stop fuzzing after detecting MAX_FAILURES errors
Review comment:
yes; the fuzzytest would have been able to catch this issue earlier - but it
was only doing 18 tests - and that was not enough...I think it makes sense to
raise the bar...so it will have more opportunities to keep us safe from issues
like this.
running 2000 takes <2 sec on my machine ; and so it could still fit into the
5sec timewindow it has
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
