julianhyde commented on issue #1335: [CALCITE-3159] Distinct can be removed for 
MIN/MAX/BIT_OR/BIT_AND agg…
URL: https://github.com/apache/calcite/pull/1335#issuecomment-517910611
 
 
   Why did you add a new overload of `RelBuilder.min`, with a `boolean 
distinct`parameter? For testing, I guess? Because no user would ever call this.
   
   Let's remove this overload.
   
   I can't tell whether you modified this change. There's just one commit, 
seven days ago. Did you squash in some changes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to