DonnyZone commented on a change in pull request #1347: [CALCITE-3224] New
RexNode-to-Expression CodeGen Implementation
URL: https://github.com/apache/calcite/pull/1347#discussion_r310633454
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
##########
@@ -741,8 +757,8 @@ public RexNode deref(RexNode expr) {
/** Translates a call to an operator or function. */
private Expression translateCall(RexCall call, RexImpTable.NullAs nullAs) {
final SqlOperator operator = call.getOperator();
- CallImplementor implementor =
- RexImpTable.INSTANCE.get(operator);
+ CallImplementor implementor = null;
Review comment:
Thanks for review!
This is the commit just for functionality. As `translateRexCall` will be
never called under new implementation, I just set null here to pass the
compilation. For review convenience, I try to minimize the changes as possible.
In latter commits (e.g., cosmetic and refactor), these unused parts will be
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
