xndai commented on a change in pull request #1358: [CALCITE-3229]
UnsupportedOperationException for UPDATE with IN query
URL: https://github.com/apache/calcite/pull/1358#discussion_r311376142
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -1800,9 +1800,12 @@ private void findSubQueries(
case ALL:
switch (logic) {
case TRUE_FALSE_UNKNOWN:
- if (validator.getValidatedNodeType(node).isNullable()) {
- break;
- } else if (true) {
Review comment:
But with your change, this check is actually removed. If it's safe to do so,
why not just completely remove these lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
