danny0405 commented on issue #1247: [CALCITE-3089] Deprecate EquiJoin URL: https://github.com/apache/calcite/pull/1247#issuecomment-519038651 > @danny0405 @hsyuan What if we added a new method to `Join`, something like: `public boolean supportsNonEquiJoin()` with a default implementation that just `return true`, and then each physical Join implementation that supports only EquiJoin conditions (like `EnumerableHashJoin` / `EnumerableMergeJoin`) will have to override it to `return false`. This method could be use as verification check by the rules, replacing somehow the current `RelOptUtil#forceEquiJoin` (which is removed by the current patch). Thanks, @rubenada , adding method to `Join` does not seem a good idea, what we only need is just let user control the behavior of the 2 rules.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
