DonnyZone commented on a change in pull request #1362: [CALCITE-3236] Handle
issues found in static code analysis
URL: https://github.com/apache/calcite/pull/1362#discussion_r311860595
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -757,7 +757,8 @@ private UnifyResult matchRecurse(MutableRel target) {
private UnifyResult apply(UnifyRule rule, MutableRel query,
MutableRel target) {
- final UnifyRuleCall call = new UnifyRuleCall(rule, query, target, null);
+ final UnifyRuleCall call =
Review comment:
This code path is never called. However, `UnifyRuleCall` requires nonNull
`slots`.
```
public UnifyRuleCall(UnifyRule rule, MutableRel query, MutableRel target,
ImmutableList<MutableRel> slots) {
this.rule = Objects.requireNonNull(rule);
this.query = Objects.requireNonNull(query);
this.target = Objects.requireNonNull(target);
this.slots = Objects.requireNonNull(slots);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
