hsyuan commented on a change in pull request #1379:
[CALCITE-3251]BinaryExpression evaluate method support Long type.
URL: https://github.com/apache/calcite/pull/1379#discussion_r314101148
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/tree/BinaryExpression.java
##########
@@ -61,6 +61,8 @@ public Object evaluate(Evaluator evaluator) {
case DOUBLE:
return (Double) expression0.evaluate(evaluator)
+ (Double) expression1.evaluate(evaluator);
+ case LONG:
+ return (Long) expression0.evaluate(evaluator) + (Long)
expression1.evaluate(evaluator);
Review comment:
Can you wrap the line just like L62~63 does? This is Calcite convention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
