chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF
like in hive
URL: https://github.com/apache/calcite/pull/1138#discussion_r314558280
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.java
##########
@@ -1069,6 +1069,20 @@ private void visitChild(SqlNode node) {
return check(type);
}
}
+
+ /**
+ * Whether the selectItem is a table function node in the select.
+ * eg. "select table_func(1) as (f0,f1)"
+ * @param selectItem select item
+ * @return true is this selectItem is a table function call
+ */
Review comment:
It should be `true if this....` instead of `true is this...`. Right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services