jinxing64 opened a new pull request #1388: [CALCITE-3262] Refine doc of SubstitutionVisitor.java URL: https://github.com/apache/calcite/pull/1388 Current doc of `SubstitutionVisitor.java` says the supported core relational operators are `@link org.apache.calcite.rel.logical.LogicalTableScan`, and so on. But with `convertTableAccess=true` (https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L5636), it's a `EnumerableTableScan` under `MutableScan`, which is inconsistent with the doc. And what's more, `MutableRels` and `SubstitutionVisitor` supporting scope doesn't limit to be `org.apache.calcite.rel.logical.LogicalXXX`. So I think it might make sense to update/refine the doc to say that the supported core relational operators are ``` * {@link org.apache.calcite.rel.core.TableScan}, * {@link org.apache.calcite.rel.core.Filter}, * {@link org.apache.calcite.rel.core.Project}, * {@link org.apache.calcite.rel.core.Join}, * {@link org.apache.calcite.rel.core.Union}, * {@link org.apache.calcite.rel.core.Aggregate}.</p> ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
