rubenada commented on a change in pull request #1369: [CALCITE-2979] Add a 
block-based nested loop join algorithm (Khawla Mouhoubi)
URL: https://github.com/apache/calcite/pull/1369#discussion_r315083126
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdCollation.java
 ##########
 @@ -450,6 +450,12 @@ public int compare(List<RexLiteral> o1, List<RexLiteral> 
o2) {
     return mq.collations(left);
   }
 
+  public static List<RelCollation> 
enumerableBatchNestedLoopJoin(RelMetadataQuery mq,
+      RelNode left, RelNode right, JoinRelType joinType) {
+    // The current implementation always preserve the sort order of the left 
input kmo does it?
 
 Review comment:
   Question to be removed at the end of the comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to