ihuzenko commented on a change in pull request #1374: [CALCITE-3138]
RelStructuredTypeFlattener doesn't restructure ROW type fields
URL: https://github.com/apache/calcite/pull/1374#discussion_r315531729
##########
File path:
core/src/main/java/org/apache/calcite/sql2rel/RelStructuredTypeFlattener.java
##########
@@ -934,7 +968,21 @@ private RexNode flattenComparison(
return conjunction;
}
}
+
+ }
+
+ private int getNewInnerOrdinal(RexNode firstOp, String literalString) {
+ int newInnerOrdinal = 0;
+ for (RelDataTypeField field : firstOp.getType().getFieldList()) {
+ if (literalString.equalsIgnoreCase(field.getName())) {
+ break;
Review comment:
1. There is no further recursive calls within the
```getNewInnerOrdinal(RexNode firstOp, String literalString)``` method. Only
recursion is applied to predict post flatten size of field which resides before
desired one, and this ```postFlattenSize(field.getType())``` prediction doesn't
require any matching.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
