julianhyde commented on issue #1369: [CALCITE-2979] Add a block-based nested loop join algorithm (Khawla Mouhoubi) URL: https://github.com/apache/calcite/pull/1369#issuecomment-523134995 I still think you should follow standard method javadoc formula. Describe what the method DOES not what it IS. If the method feels more like a noun than a verb that is telling you something, right...? The only exception I could find is the `hashJoin_` method, which is private and furthermore named to indicate that it is low-level implementation. Whereas your method is public.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
