danny0405 commented on a change in pull request #1338: [CALCITE-3210] Fix the
bug that RelToSqlConverter converts "cast(null as $type)" just as null
URL: https://github.com/apache/calcite/pull/1338#discussion_r316077549
##########
File path:
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -3694,6 +3694,95 @@ private void checkLiteral2(String expression, String
expected) {
assertTrue(postgresqlDialect.supportsDataType(integerDataType));
}
+ @Test public void testSelectNull() {
+ String query = "SELECT CAST(NULL AS INT)";
+ final String expected = "SELECT CAST(NULL AS INTEGER)\n"
+ + "FROM (VALUES (0)) AS \"t\" (\"ZERO\")";
+ sql(query).ok(expected);
+ // validate
+ sql(expected).exec();
+ }
+
+ @Test public void testSelectNullWithCount() {
+ String query = "SELECT COUNT(CAST(NULL AS INT))";
+ final String expected = "SELECT COUNT(CAST(NULL AS INTEGER))\n"
+ + "FROM (VALUES (0)) AS \"t\" (\"ZERO\")";
+ sql(query).ok(expected);
+ // validate
+ sql(expected).exec();
+ }
+
+ @Test public void testSelectNullWithGroupByNull() {
+ String query = "SELECT COUNT(CAST(NULL AS INT)) FROM (VALUES (0)) "
+ + "AS \"t\" GROUP BY CAST(NULL AS VARCHAR CHARACTER SET
\"ISO-8859-1\")";
+ final String expected = "SELECT COUNT(CAST(NULL AS INTEGER))\n"
+ + "FROM (VALUES (0)) AS \"t\" (\"EXPR$0\")\nGROUP BY CAST(NULL "
+ + "AS VARCHAR CHARACTER SET \"ISO-8859-1\")";
+ sql(query).ok(expected);
+ // validate
+ sql(expected).exec();
+ }
+
+ @Test public void testSelectNullWithGroupByVar() {
+ String query = "SELECT COUNT(CAST(NULL AS INT)) FROM \"account\" "
+ + "AS \"t\" GROUP BY \"account_type\"";
+ final String expected = "SELECT COUNT(CAST(NULL AS INTEGER))\n"
+ + "FROM \"foodmart\".\"account\"\n"
+ + "GROUP BY \"account_type\"";
+ sql(query).ok(expected);
+ // validate
+ sql(expected).exec();
+ }
+
+ @Test public void testSelectNullWithInsert() {
+ String query = "insert into "
+ +
"\"account\"(\"account_id\",\"account_parent\",\"account_type\",\"account_rollup\")"
+ + " select 1, cast(NULL AS INT), cast(123 as varchar), cast(123 as
varchar)";
+ final String expected = "INSERT INTO \"foodmart\".\"account\" ("
+ + "\"account_id\", \"account_parent\", \"account_description\", "
+ + "\"account_type\", \"account_rollup\", \"Custom_Members\")\n"
+ + "(SELECT 1 AS \"account_id\", CAST(NULL AS INTEGER) AS
\"account_parent\","
+ + " CAST(NULL AS VARCHAR(30) CHARACTER SET "
+ + "\"ISO-8859-1\") AS \"account_description\", '123' AS
\"account_type\", "
+ + ""
+ + "'123' AS \"account_rollup\", CAST(NULL AS VARCHAR"
+ + "(255) CHARACTER SET \"ISO-8859-1\") AS \"Custom_Members\"\n"
+ + "FROM (VALUES (0)) AS \"t\" (\"ZERO\"))";
+ sql(query).ok(expected);
+ // validate
+ sql(expected).exec();
+ }
+
+ @Test public void testSelectNullWithInsertFromJoin() {
+ String query = "insert into "
+ +
"\"account\"(\"account_id\",\"account_parent\",\"account_type\",\"account_rollup\")"
+ + "\tselect \"product\".\"product_id\", \n"
+ + "\tcast(NULL AS INT), \n"
+ + "\tcast(\"product\".\"product_id\" as varchar), \n"
Review comment:
Can we replace all these "\t" with "\n" ? Also put a "\n" at the end of
every sql statement line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
