Fokko commented on a change in pull request #1393: [CALCITE-3265] Remove the
unused variables
URL: https://github.com/apache/calcite/pull/1393#discussion_r316624501
##########
File path: core/src/main/java/org/apache/calcite/runtime/Matcher.java
##########
@@ -63,7 +58,6 @@ private Matcher(Automaton automaton,
ImmutableBitSet.builder();
startSetBuilder.set(automaton.startState.id);
automaton.epsilonSuccessors(automaton.startState.id, startSetBuilder);
- startSet = startSetBuilder.build();
Review comment:
Still, we don't do anything meaningful with `startSet`. We could change the
line to `startSetBuilder.build();` if we don't want to change behavior. WDYT?
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/util/ImmutableBitSet.java#L958-L968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
