julianhyde commented on a change in pull request #1393: [CALCITE-3265] Remove
the unused variables
URL: https://github.com/apache/calcite/pull/1393#discussion_r316824569
##########
File path: core/src/main/java/org/apache/calcite/runtime/Matcher.java
##########
@@ -63,7 +58,6 @@ private Matcher(Automaton automaton,
ImmutableBitSet.builder();
startSetBuilder.set(automaton.startState.id);
automaton.epsilonSuccessors(automaton.startState.id, startSetBuilder);
- startSet = startSetBuilder.build();
Review comment:
`Matcher` is a work in progress, because we only have a basic implementation
of `MATCH_RECOGNIZE` right now. I don't know what we will eventually need. We
might need `startSetBuilder` when we implement the `classifier()` operator in
`MATCH_RECOGNIZE`.
Let's not try to tidy up that code right now. It's a construction site.
There are things in it that are not used now that I added for a reason because
I was thinking about the whole problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
