danny0405 commented on a change in pull request #1403: [CALCITE-3283]
RelSubSet's best is not existed in the set
URL: https://github.com/apache/calcite/pull/1403#discussion_r316956324
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -1440,6 +1447,11 @@ void rename(RelNode rel) {
boolean existed = subset.set.rels.remove(rel);
assert existed : "rel was not known to its set";
final RelSubset equivSubset = getSubset(equivRel);
+ if (subset.best == rel) {
+ subset.best = equivRel;
Review comment:
Nice catch !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
