danny0405 commented on a change in pull request #1397: [CALCITE-3115] Cannot
add JdbcRules which have different JdbcConvention to same VolcanoPlanner's
RuleSet.
URL: https://github.com/apache/calcite/pull/1397#discussion_r317048633
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -262,6 +263,17 @@ private JdbcRules() {
this(clazz, (Predicate<R>) predicate, in, out, relBuilderFactory,
description);
}
+
+ /**
+ * Creates name for child JdbcConverter rules in format:
+ * RuleName(out:CONVENTION_NAME)
+ *
+ * @param out output convention
+ * @return rule name
+ */
+ protected static String getRuleName(Class<?> clazz, JdbcConvention out) {
+ return String.format(Locale.ROOT, "%s(out:%s)", clazz.getSimpleName(),
out);
+ }
Review comment:
I checked again and almost every adapter converter rules do not include the
convention in their description, maybe we can alway include the convention into
the rule name and unify the logic into `ConverterRule`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
