xndai commented on issue #1403: [CALCITE-3283] RelSubSet's best is not existed in the set URL: https://github.com/apache/calcite/pull/1403#issuecomment-524596052 > Looks like with this change the issue still exists, see `JdbcTest.testInnerJoinValues` and `agg.iq`. With this PR you shouldn't see error message like "RelSubset doesn't contain its best node", which indeed is the case. But there are still a bunch of failures related to "rel has lower cost than best cost..." which will be taken care by CALCITE-2018. So it looks like I can not just enable isValid() under assert before we completely fix all these issues.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
