danny0405 commented on a change in pull request #1401: [CALCITE-3280] Add
regexp_replace function (Shuming Li)
URL: https://github.com/apache/calcite/pull/1401#discussion_r317467774
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -450,6 +451,24 @@ public Expression implement(RexToLixTranslator translator,
NotImplementor.of(posixRegexImplementor), false);
defineImplementor(SqlStdOperatorTable.NEGATED_POSIX_REGEX_CASE_SENSITIVE,
NullPolicy.STRICT,
NotImplementor.of(posixRegexImplementor), false);
+ defineImplementor(REGEXP_REPLACE, NullPolicy.STRICT,
+ new NotNullImplementor() {
+ final NotNullImplementor[] implementors = {
+ new ReflectiveCallNotNullImplementor(
+ BuiltInMethod.REGEXP_REPLACE3.method),
+ new ReflectiveCallNotNullImplementor(
+ BuiltInMethod.REGEXP_REPLACE4.method),
+ new ReflectiveCallNotNullImplementor(
+ BuiltInMethod.REGEXP_REPLACE5.method),
+ new ReflectiveCallNotNullImplementor(
+ BuiltInMethod.REGEXP_REPLACE6.method)
+ };
+ public Expression implement(RexToLixTranslator translator,
+ RexCall call, List<Expression>
translatedOperands) {
Review comment:
Fix the indents with 2 tabs also give a comment why we should minus a
hardcode `3` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
