chunweilei commented on a change in pull request #1406: [CALCITE-3243]
Incomplete validation of operands in JSON functions
URL: https://github.com/apache/calcite/pull/1406#discussion_r317575544
##########
File path: core/src/test/java/org/apache/calcite/sql/test/SqlTests.java
##########
@@ -350,6 +350,16 @@ public static void checkEx(Throwable ex,
}
Throwable actualException = ex;
String actualMessage = actualException.getMessage();
+
+ // If sap does not contain an error location, just check whether an
exception
+ // matches the expected pattern.
+ if (sap.pos == null) {
+ if (expectedMsgPattern != null
+ && actualMessage.matches(expectedMsgPattern)) {
+ return;
Review comment:
These conditions can be simplified to one if as follows.
```
if (sap.pos == null && expectedMsgPattern != null
&& actualMessage.matches(expectedMsgPattern))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
