xy2953396112 commented on a change in pull request #1409: [CALCITE-3289]
Disable test pending fix for Wikipedia format change
URL: https://github.com/apache/calcite/pull/1409#discussion_r317585724
##########
File path:
file/src/test/java/org/apache/calcite/adapter/file/FileReaderTest.java
##########
@@ -68,6 +68,7 @@ private static String resourcePath(String path) throws
Exception {
}
/** Tests {@link FileReader} URL instantiation - no path. */
+ @Ignore("[CALCITE-3289] Wikipedia format change breaks file adapter test")
@Test public void testFileReaderUrlNoPath() throws FileReaderException {
Assume.assumeTrue(FileSuite.hazNetwork());
Review comment:
run the testFileReaderUrlNoPath,get the Exception in my mac.
org.junit.AssumptionViolatedException: got: <false>, expected: is <true>
at org.junit.Assume.assumeThat(Assume.java:95)
at org.junit.Assume.assumeTrue(Assume.java:41)
Maybe we could ignore this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
