yanlin-Lynn commented on a change in pull request #1411: [CALCITE-3290]
Implement evaluate method of AbstractNode
URL: https://github.com/apache/calcite/pull/1411#discussion_r317590584
##########
File path: linq4j/src/main/java/org/apache/calcite/linq4j/tree/Evaluator.java
##########
@@ -22,11 +22,11 @@
/**
* Holds context for evaluating expressions.
*/
-class Evaluator {
+public class Evaluator {
final List<ParameterExpression> parameters = new ArrayList<>();
final List<Object> values = new ArrayList<>();
- Evaluator() {
+ public Evaluator() {
}
Review comment:
FYI: Seems to be the same as this PR:
https://github.com/apache/calcite/pull/1387
See the discusstion in this jira:
https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-3260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
