danny0405 commented on a change in pull request #1402: [CALCITE-3282] Make
every SqlDialect unparse their own data type
URL: https://github.com/apache/calcite/pull/1402#discussion_r318533726
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java
##########
@@ -1088,7 +1088,12 @@ public boolean isCaseSensitive() {
return caseSensitive;
}
- /**
+ public void unparseDataType(final SqlWriter writer, final SqlDataTypeSpec
sqlDataTypeSpec,
+ final int leftPrec, final int rightPrec) {
+ sqlDataTypeSpec.getTypeNameSpec().unparse(writer, leftPrec, rightPrec);
+ }
Review comment:
I think we should invoke `sqlDataTypeSpec#unparse` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
