wenhuitang commented on issue #1397: [CALCITE-3115] Cannot add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet. URL: https://github.com/apache/calcite/pull/1397#issuecomment-527114223 Sorry for replying too late., I have been busy with other things in the past few months so that I have not noticed these comments. @ihuzenko Thanks for you PR, It's good. But I notice that it still not solve the problem that the result of JdbcConvention#toString() maybe not obey the description pattern of the RelOptRule. Since the convention name can be assigned when JdbcSchema is created and the name maybe not valid in a rule description. So if we can not find a way to normalize the convention name, can we throw a prompt to the client?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
