danny0405 commented on a change in pull request #1435: [hotfix]Remove the
useless JdbcConvention out in descriptionPrefix for
JdbcToEnumerableConverterRule.
URL: https://github.com/apache/calcite/pull/1435#discussion_r319961977
##########
File path:
core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcToEnumerableConverterRule.java
##########
@@ -35,7 +35,7 @@ public JdbcToEnumerableConverterRule(JdbcConvention out,
RelBuilderFactory relBuilderFactory) {
super(RelNode.class, (Predicate<RelNode>) r -> true, out,
EnumerableConvention.INSTANCE, relBuilderFactory,
- "JdbcToEnumerableConverterRule:" + out);
+ "JdbcToEnumerableConverterRule");
Review comment:
@wenhuitang Can you please help to make sure that all the `ConverterRule`
sub-class all have the right description prefix ? Really thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
