shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting
new parameter from model to set it in HTTP host…
URL: https://github.com/apache/calcite/pull/1447#discussion_r322434323
##########
File path:
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java
##########
@@ -62,8 +62,9 @@ public ElasticsearchSchemaFactory() {
final Map<String, Integer> coordinates =
mapper.readValue(coordinatesString,
new TypeReference<Map<String, Integer>>() { });
+ final String scheme = (String) map.get("scheme");
Review comment:
Introduced new variable *hosts* in parallel to coordinates to maintain
backward compatibility.
Either hosts or coordinates is required to connect to ES. If hosts is
provided it should be a well-formed URL having protocol, host and port
information. Hosts can take any number of hosts.
With coordinates it works as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
