JulianFeinauer commented on issue #1449: [CALCITE-3302] Implement CLASSIFIER and LAST function for MATCH_RECOG… URL: https://github.com/apache/calcite/pull/1449#issuecomment-530132461 > I didn't have time to follow the logic on first review, but it looks good. I only have quibbles about naming and formatting. How about 'SqlMatchFunction' instead of 'SqlMrFunction'? (We tend to abbreviate "match-recognize" to "match", so there's no need for the "mr" acronym.) > > Also we tend to put parentheses on the end of the line, so > > ``` > foo( > bar))); > ``` > > rather than > > ``` > foo( > bar) > )); > ``` Agree with both of your points, I updated the branch respectively. I hope I found (nearly) all places with the bracket-thingy. Thanks @julianhyde!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
