danny0405 commented on a change in pull request #1448: [CALCITE-3332] Query
failed with AssertionError: cannot cast null as class java.math.BigDecima
URL: https://github.com/apache/calcite/pull/1448#discussion_r323072326
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlOperatorBinding.java
##########
@@ -150,7 +150,7 @@ public Comparable getOperandLiteralValue(int ordinal) {
* <p>This is only relevant for SQL validation.
*
* @param ordinal zero-based ordinal of operand of interest
- * @param allowCast whether to regard CAST(constant) as a constant
+ * @param allowCast whether to regard CAST(null) as null
* @return whether operand is null; false for everything except SQL
Review comment:
Why to change the comment, look at the implementation in
`SqlUtil#isNullLiteral`, you have change the semantics to be wrong, please
change it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
