jacob-roldan commented on a change in pull request #1452: [WIP][CALCITE-3338]
Error with executeBatch and preparedStatement when usi…
URL: https://github.com/apache/calcite/pull/1452#discussion_r324191351
##########
File path:
core/src/main/java/org/apache/calcite/jdbc/CalciteConnectionImpl.java
##########
@@ -279,18 +279,26 @@ public Properties getProperties() {
CalciteStatement statement = (CalciteStatement) createStatement();
CalcitePrepare.CalciteSignature<T> signature =
statement.prepare(queryable);
- return enumerable(statement.handle, signature).enumerator();
+ return enumerable(statement.handle, signature, null).enumerator();
} catch (SQLException e) {
throw new RuntimeException(e);
}
}
public <T> Enumerable<T> enumerable(Meta.StatementHandle handle,
- CalcitePrepare.CalciteSignature<T> signature) throws SQLException {
+ CalcitePrepare.CalciteSignature<T> signature,
+ List<TypedValue> parameterValues0) throws SQLException {
Map<String, Object> map = new LinkedHashMap<>();
AvaticaStatement statement = lookupStatement(handle);
- final List<TypedValue> parameterValues =
+
+ final List<TypedValue> parameterValues1 =
TROJAN.getParameterValues(statement);
Review comment:
This method will be executed although parameterValues0 has elements, won't
it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
